Combined docker files #1623
Combined docker files #1623
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| restart: unless-stopped | ||
| environment: | ||
| POSTGRES_DB: "intermediary" | ||
| POSTGRES_PASSWORD: "changeIT!" # pragma: allowlist secret |
There was a problem hiding this comment.
Consider using environment variables for database credentials to enhance security. This can be done by setting up environment variables in your CI/CD pipeline or local environment, and referencing them in the docker-compose file. [important]
|
|
||
| postgresql: | ||
| image: postgres:16 | ||
| restart: unless-stopped |
There was a problem hiding this comment.
It's recommended to avoid using 'unless-stopped' for the restart policy of containers in production environments. Consider using 'always' or a specific restart policy that aligns with your deployment strategy. [medium]
| @@ -56,7 +56,7 @@ creates a `.env` file in the resource folder with the required configuration | |||
|
|
|||
| ### Using a local database | |||
|
|
|||
| Use [docker-compose.postgres.yml](docker-compose.postgres.yml) to run your local DB. In IntelliJ, you can click the play arrow to start it | |||
| Use [docker-compose.yml](docker-compose.yml) to run your local DB. In IntelliJ, you can click the play arrow to start it | |||
There was a problem hiding this comment.
Update the documentation to reflect the removal of 'docker-compose.postgres.yml' and ensure all references are correctly pointing to 'docker-compose.yml'. This helps in maintaining accurate and useful documentation. [important]
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
Description
Describe what changed in this PR at a high level.
Issue
Add a link to the issue here. Consider using
closing keywords
if the this PR isn't for a story (stories will be closed through different means).
Checklist
Note: You may remove items that are not applicable